Fix over-matching of quoted text for message bodies beginning with "On..."
ClosedPublic
Actions

Authored by epriestley on Dec 6 2013, 11:41 PM.

Tags

None

Referenced Files

	F14032829: D7732.diff
	Sat, Nov 9, 3:55 PM

	F14024136: D7732.diff
	Thu, Nov 7, 6:23 AM

	F13998125: D7732.diff
	Thu, Oct 24, 7:42 AM

	F13975598: D7732.diff
	Fri, Oct 18, 10:53 AM

	F13966596: D7732.id17465.diff
	Wed, Oct 16, 8:38 AM

	F13960761: D7732.id.diff
	Tue, Oct 15, 1:14 AM

	Unknown Object (File)
	Oct 2 2024, 2:04 AM

	Unknown Object (File)
	Aug 25 2024, 12:53 PM

View All Files

Subscribers

aran

Details

Reviewers

zeeg
btrahan

Commits

Restricted Diffusion Commit
rPf69793184e0b: Fix over-matching of quoted text for message bodies beginning with "On..."

Summary

A user sent a message to Phabricator which looked like:

On blah blah blah ?

On <date>, <user> wrote:
> blah blah blah

The current algorithm is too aggressive and thinks lines 1-3 are all the "On ... wrote:" string. Instead, patch only the most recent "On".

Test Plan

Added a failing test and made it pass.

Diff Detail

Branch

quotetext

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

literally only read the test code

Closed by commit rPf69793184e0b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

parser/

PhabricatorMetaMTAEmailBodyParser.php

27 lines

__tests__/

PhabricatorMetaMTAEmailBodyParserTestCase.php

14 lines

Diff 17464

View Options

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

View Options

src/applications/metamta/parser/tests/PhabricatorMetaMTAEmailBodyParserTestCase.php

Fix over-matching of quoted text for message bodies beginning with "On..."ClosedPublicActions