Fix over-matching of quoted text for message bodies beginning with "On..."
ClosedPublic
Actions

Authored by epriestley on Dec 6 2013, 11:41 PM.

Tags

None

Referenced Files

	F15467150: D7732.diff
	Thu, Apr 3, 1:09 PM

	F15388893: D7732.id.diff
	Sat, Mar 15, 4:35 AM

	Unknown Object (File)
	Mar 1 2025, 2:38 PM

	Unknown Object (File)
	Feb 10 2025, 11:48 PM

	Unknown Object (File)
	Feb 10 2025, 10:00 PM

	Unknown Object (File)
	Feb 9 2025, 10:46 AM

	Unknown Object (File)
	Feb 9 2025, 10:46 AM

	Unknown Object (File)
	Feb 9 2025, 10:46 AM

View All Files

Subscribers

aran

Details

Reviewers

zeeg
btrahan

Commits

Restricted Diffusion Commit
rPf69793184e0b: Fix over-matching of quoted text for message bodies beginning with "On..."

Summary

A user sent a message to Phabricator which looked like:

On blah blah blah ?

On <date>, <user> wrote:
> blah blah blah

The current algorithm is too aggressive and thinks lines 1-3 are all the "On ... wrote:" string. Instead, patch only the most recent "On".

Test Plan

Added a failing test and made it pass.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

literally only read the test code

Closed by commit rPf69793184e0b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

parser/

PhabricatorMetaMTAEmailBodyParser.php

27 lines

__tests__/

PhabricatorMetaMTAEmailBodyParserTestCase.php

14 lines

Diff 17465

View Options

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

View Options

src/applications/metamta/parser/tests/PhabricatorMetaMTAEmailBodyParserTestCase.php

Fix over-matching of quoted text for message bodies beginning with "On..."ClosedPublicActions