Page MenuHomePhabricator

Multicolor headers
ClosedPublic

Authored by chad on Dec 6 2013, 5:03 PM.
Tags
None
Referenced Files
F13086484: D7731.diff
Thu, Apr 25, 12:28 AM
F13083347: D7731.diff
Wed, Apr 24, 10:30 PM
Unknown Object (File)
Sat, Apr 20, 6:09 PM
Unknown Object (File)
Thu, Apr 11, 9:17 AM
Unknown Object (File)
Mar 21 2024, 8:25 AM
Unknown Object (File)
Mar 3 2024, 5:43 AM
Unknown Object (File)
Mar 3 2024, 5:39 AM
Unknown Object (File)
Feb 23 2024, 3:23 PM

Details

Summary

This adds a handful of 'Main Header' colors to change the look of Phabricator very slightly. I know I would probably set my dev header to a different color.

Test Plan

Tested each css class and color, can add more in the future.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Code looks good. My vote for admin vs user inline. I'd accept, but I wasn't sure if there was some sort of debate on this though?

src/view/page/menu/PhabricatorMainMenuView.php
71

i think i like this as a user preference

Meh, I think I dreamed the debate.

I have a mild preference for admin since logged-out is easier if it's per-install. Is your vote for per-user strong enough that you want to write the pref panel? :)

How should we deal with logged-out if it's per-user?

Admin only is fine with me, I don't think actual end users have asked for this. I will use it to make my dev install different than secure.

Forgot about logged out so admin works for me.

Cool, I can kick a diff out in a bit.

@chad - you mentioned " I don't think actual end users have asked for this." re - these changes for non-admins.

Just to offer a different use case - we're evaluating phabricator for our dev work on Mozilla Webmaker (www.webmaker.org), and we really want users of that site to take an active role in helping not only file tickets and see how the sausage is made, but use working on the site as a sort of curriculum to teach the web.

In that case, we'd want to be able to offer an experience that does feel close to the rest of the site - simple colours and an image in the header would probably suffice, but it is something we'd want to offer public, logged in and admins.

It wouldn't be the factor for us to decide to move all of our tooling, but would certainly be a nice touch for our users.

Really impressed by this software and the speed at which you're iterating on it

I added T4213 to discuss some of the forces here. The short version is that we're unlikely to support fully custom CSS in the upstream anytime soon, although if colors and a logo are good enough that may be in the cards in the near future. This adds colors (and will be selectable in the UI in a few hours, once I actually write a patch for the option), and the logo stuff is something we've talked about in the past, although there's some technical stuff around serving ad-hoc static resources properly and making it work on mobile/devices. I'll file something explicitly.

(Chad has some sporadic commitments for the next couple of weeks, so even if we come up with a plan of attack and everyone's on the same page, it might be a little bit before we get it into the upstream.)

many thanks, its incredible how fast your team react on feature request. have a good weekend.

  • D7740 puts the UI for picking this in place.
  • T4214 discusses the logo issue, specifically.