Page MenuHomePhabricator

Add an SSH access log
ClosedPublic

Authored by epriestley on Dec 5 2013, 9:48 PM.
Tags
None
Referenced Files
F14074413: D7719.diff
Thu, Nov 21, 6:33 AM
Unknown Object (File)
Sun, Nov 17, 8:02 AM
Unknown Object (File)
Fri, Nov 15, 9:37 AM
Unknown Object (File)
Fri, Nov 15, 9:37 AM
Unknown Object (File)
Fri, Nov 15, 9:37 AM
Unknown Object (File)
Thu, Oct 24, 11:17 AM
Unknown Object (File)
Thu, Oct 24, 11:11 AM
Unknown Object (File)
Thu, Oct 24, 11:10 AM
Subscribers

Details

Summary

Ref T4107. Ref T4189. This implements an SSH access log, similar to the HTTP access log.

Test Plan
[Thu, 05 Dec 2013 13:45:41 -0800]	77841	orbital	::1	dweller	epriestley	epriestley	git-receive-pack	/diffusion/POEMS/	0	324765	402	232
[Thu, 05 Dec 2013 13:45:48 -0800]	77860	orbital	::1	dweller	epriestley	epriestley	git-receive-pack	/diffusion/POEMS/	0	325634	402	232

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
scripts/ssh/ssh-exec.php
138

maybe throw $rethrow? or can you just set $ex = null before the try / catch block and change the if to $ex?

scripts/ssh/ssh-exec.php
138

Ah, yeah, thanks! I meant throw $rethrow;.