Page MenuHomePhabricator

Implement explicit build step ordering in Harbormaster
ClosedPublic

Authored by hach-que on Dec 5 2013, 10:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:29 AM
Unknown Object (File)
Fri, Apr 19, 3:29 AM
Unknown Object (File)
Fri, Apr 19, 3:29 AM
Unknown Object (File)
Thu, Apr 11, 4:41 AM
Unknown Object (File)
Wed, Apr 10, 1:37 AM
Unknown Object (File)
Sun, Mar 31, 3:48 PM
Unknown Object (File)
Mar 26 2024, 8:03 AM
Unknown Object (File)
Mar 26 2024, 8:03 AM

Details

Summary

This implements support for explicitly marking the sequence of build steps. Users can now drag and re-order build steps in plans, and artifact dependencies are re-calculated so that if you move "Run Command" before "Lease Host", the "Run Command" step has it's artifact setting cleared and thus the step becomes invalid.

Test Plan

Re-ordered build steps and observed dependencies being correctly recalculated.

Diff Detail

Branch
step-ordering
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed

Event Timeline