Page MenuHomePhabricator

Implement explicit build step ordering in Harbormaster
ClosedPublic

Authored by hach-que on Dec 5 2013, 10:53 AM.
Tags
None
Referenced Files
F19812979: D7715.diff
Wed, Mar 4, 7:02 AM
F19720074: D7715.id17421.diff
Thu, Feb 12, 8:04 PM
F19292326: D7715.id17421.diff
Dec 23 2025, 9:37 AM
F18906970: D7715.id.diff
Nov 8 2025, 9:27 PM
F18905743: D7715.id17421.diff
Nov 8 2025, 3:30 PM
F18867019: D7715.diff
Nov 3 2025, 9:00 PM
F18823073: D7715.id.diff
Oct 23 2025, 10:05 AM
F18807667: D7715.id17421.diff
Oct 19 2025, 2:49 AM

Details

Summary

This implements support for explicitly marking the sequence of build steps. Users can now drag and re-order build steps in plans, and artifact dependencies are re-calculated so that if you move "Run Command" before "Lease Host", the "Run Command" step has it's artifact setting cleared and thus the step becomes invalid.

Test Plan

Re-ordered build steps and observed dependencies being correctly recalculated.

Diff Detail

Branch
step-ordering
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed

Event Timeline