Page MenuHomePhabricator

Implement explicit build step ordering in Harbormaster
ClosedPublic

Authored by hach-que on Dec 5 2013, 10:53 AM.
Tags
None
Referenced Files
F18906970: D7715.id.diff
Sat, Nov 8, 9:27 PM
F18905743: D7715.id17421.diff
Sat, Nov 8, 3:30 PM
F18867019: D7715.diff
Mon, Nov 3, 9:00 PM
F18823073: D7715.id.diff
Oct 23 2025, 10:05 AM
F18807667: D7715.id17421.diff
Oct 19 2025, 2:49 AM
F18782767: D7715.diff
Oct 13 2025, 2:33 AM
F18739991: D7715.id17446.diff
Oct 1 2025, 11:50 PM
F18098587: D7715.id17421.diff
Aug 8 2025, 9:28 PM

Details

Summary

This implements support for explicitly marking the sequence of build steps. Users can now drag and re-order build steps in plans, and artifact dependencies are re-calculated so that if you move "Run Command" before "Lease Host", the "Run Command" step has it's artifact setting cleared and thus the step becomes invalid.

Test Plan

Re-ordered build steps and observed dependencies being correctly recalculated.

Diff Detail

Branch
step-ordering
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed

Event Timeline