Currently the "Edit Build Plan" page crashes if there are any build steps with invalid implementations (because the implementation class has been removed or renamed). This updates the Edit Build Plan page so that steps with invalid implementations can be deleted.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4111: Use Drydock to allocate build machines for Harbormaster
T1049: Implement Harbormaster - Commits
- Restricted Diffusion Commit
rPa8b27130cbcd: Make "Edit Build Plan" more resiliant so old build configurations can be deleted
Looked at a build plan with invalid configurations and deleted it's steps.
Diff Detail
Diff Detail
- Branch
- resiliance
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
Seems reasonable to me.
| src/applications/harbormaster/controller/HarbormasterPlanViewController.php | ||
|---|---|---|
| 99 | Maybe put the (presumed bad) implementation class into the message? Might help debug things. | |