This adds LeaseHostBuildStepImplementation for getting leases on hosts in Drydock via Harbormaster. It stores the resulting lease in an artifact.
There is also a few bug fixes as well.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T1049: Implement Harbormaster
T4111: Use Drydock to allocate build machines for Harbormaster - Commits
- Restricted Diffusion Commit
rPd8d1173f5297: Implement support for leasing from Drydock hosts in Harbormaster
Created a build plan with a "Lease Host" build step. Ran the build plan and saw the build pass and the artifact in the database.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/harbormaster/step/BuildStepImplementation.php | ||
|---|---|---|
| 59–70 | We need to load settings against either HarbormasterBuildStep or HarbormasterBuildTarget. | |
| src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php | ||
| 44–62 | Need this back in HarbormasterBuildStep in addition to HarbormasterBuildTarget since we need to be able to create implementations in the build plan editor (where there's no targets). | |
| src/applications/harbormaster/step/BuildStepImplementation.php | ||
|---|---|---|
| 59–70 | Maybe cleaner to provide loadSettingsFromBuildTarget and loadSettingsFromBuildStep, but this is easy to clean up later. | |
| src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php | ||
| 45 | Prefer the verb load to get, so it's more clear that the method does service calls. | |
| src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php | ||
| 44–62 | We should maybe do dummy targets or something, but not a big deal to sort out later. | |