Support "ssh-dss" keys
ClosedPublic
Actions

Authored by epriestley on Dec 5 2013, 12:43 AM.

Tags

None

Referenced Files

	F14356916: D7704.diff
	Fri, Dec 20, 1:32 AM

	Unknown Object (File)
	Tue, Dec 17, 7:22 PM

	Unknown Object (File)
	Fri, Dec 13, 1:13 AM

	Unknown Object (File)
	Mon, Dec 9, 6:30 AM

	Unknown Object (File)
	Sun, Dec 8, 1:22 PM

	Unknown Object (File)
	Fri, Dec 6, 4:48 PM

	Unknown Object (File)
	Thu, Nov 28, 8:47 PM

	Unknown Object (File)
	Thu, Nov 28, 3:34 PM

View All Files

Subscribers

aran

Tokens

"Like" token, awarded by dctrwatson.

Details

Reviewers

phpcodemonkey
btrahan
dctrwatson

Maniphest Tasks

T4151: Cleanup and errata for repository hosting

Commits

Restricted Diffusion Commit
rP2aad7289fd2f: Support "ssh-dss" keys

Summary

Ref T4151. These are a (common) variant of "ssh-dsa" keys (which are somewhat theoretical, but show up on Google).

Test Plan

syntax

Diff Detail

Branch

dss

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Add a keytype for @dctrwatson.

Also handle ecdsa..384.

Looks good to me, ship it! :)

Closed by commit rP2aad7289fd2f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorSettingsPanelSSHKeys.php

2 lines

Diff 17399

View Options

src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php

Support "ssh-dss" keysClosedPublicActions