Page MenuHomePhabricator

Add Action Buttons to ObjectHeaders
ClosedPublic

Authored by chad on Dec 2 2013, 11:33 PM.
Tags
None
Referenced Files
F14024184: D7684.diff
Thu, Nov 7, 6:54 AM
F14006196: D7684.id.diff
Mon, Oct 28, 2:50 AM
F13990869: D7684.diff
Tue, Oct 22, 6:54 AM
F13985130: D7684.id17362.diff
Sun, Oct 20, 6:08 PM
Unknown Object (File)
Oct 2 2024, 4:13 PM
Unknown Object (File)
Sep 1 2024, 8:37 AM
Unknown Object (File)
Sep 1 2024, 7:28 AM
Unknown Object (File)
Aug 28 2024, 5:33 AM

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP9942c2a39ee1: Add Action Buttons to ObjectHeaders
Summary

This adds the ability to float action buttons inside ObjectHeaderView.

Test Plan

Tested a UI Example on desktop and mobile. Will test on Notifications next.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

It would maybe be nice for the non-hover state to at least hint that it's a button, maaaaaybe? Not sure if that looks like junk in practice. But this looks similar to action links anyway and doesn't have the same sneakiness to it that the "Mark All Read" link did.

My plan is to just go with it as is on the Notifications page and see how it feels. I've been liking the 'button-less' button look when using Google Analytics, but it may or may not work for us. The current buttons we have are just a bit heavy for the headers, so many gradients...