Support SVN pre-commit hoooks
ClosedPublic
Actions

Authored by epriestley on Dec 2 2013, 10:32 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4189: Install commit hooks in hosted repositories

Commits

Restricted Diffusion Commit
rP017d6ccd0793: Support SVN pre-commit hoooks

Summary

Ref T4189. This adds SVN support, which was a little more messy than I though. Principally, we can not use PHABRICATOR_USER for Subversion, because it strips away the entire environment for "security reasons".

Instead, use --tunnel-user plus svnlook author to figure out the author.

Also fix "ssh://" clone URIs, which needs to be "svn+ssh://".

Test Plan

Made SVN commits through the hook.
Made Git commits, too, to make sure I didn't break anything.

Diff Detail

Branch

hooks2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/diffusion/engine/DiffusionCommitHookEngine.php:71	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

Fix argument order in an exception message.

cool, just an inline about how it works

scripts/repository/commit_hook.php
27–32	so when does this check get done now?

epriestley added inline comments.Dec 2 2013, 10:41 PM

scripts/repository/commit_hook.php
27–32	We'll never get here if the user doesn't have PUSH -- they'll be rejected as early as possible, before they send any data (in the case of SVN, before they send more than a few frames of data). (I'll probably put this check back into the HookEngine just to be extra safe, though.)