Page MenuHomePhabricator

Shorten extremely long credential names when migrating them
ClosedPublic

Authored by epriestley on Dec 2 2013, 2:21 PM.
Tags
None
Referenced Files
F18815973: D7677.id17344.diff
Tue, Oct 21, 4:29 AM
F18654093: D7677.diff
Sep 22 2025, 2:35 AM
F18608795: D7677.diff
Sep 14 2025, 2:01 AM
F18473526: D7677.id17344.diff
Sep 2 2025, 9:33 PM
F18446875: D7677.id17335.diff
Aug 31 2025, 10:25 PM
F18394859: D7677.id17344.diff
Aug 29 2025, 10:33 AM
F18392511: D7677.id17344.diff
Aug 29 2025, 8:20 AM
F18377472: D7677.id.diff
Aug 28 2025, 1:03 PM
Subscribers

Details

Summary

Fixes T4183. If you have too many repositories sharing the same credential and MySQL is in strict mode, we'll fail a query when trying to write a credential with a name longer than 255 characters. Instead, shorten the variable-length part to 128 characters.

Test Plan

Wiped credentials column and successfully re-ran migration with storage upgrade --force --apply phabricator:20131121.repocredentials.2.mig.php

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped