Page MenuHomePhabricator

Shorten extremely long credential names when migrating them
ClosedPublic

Authored by epriestley on Dec 2 2013, 2:21 PM.
Tags
None
Referenced Files
F19089501: D7677.diff
Wed, Dec 3, 7:31 AM
F19081562: D7677.id17335.diff
Tue, Dec 2, 7:26 AM
F19011283: D7677.diff
Sat, Nov 22, 8:57 AM
F18856242: D7677.id.diff
Nov 1 2025, 8:47 AM
F18852171: D7677.diff
Oct 31 2025, 7:14 AM
F18815973: D7677.id17344.diff
Oct 21 2025, 4:29 AM
F18654093: D7677.diff
Sep 22 2025, 2:35 AM
F18608795: D7677.diff
Sep 14 2025, 2:01 AM
Subscribers

Details

Summary

Fixes T4183. If you have too many repositories sharing the same credential and MySQL is in strict mode, we'll fail a query when trying to write a credential with a name longer than 255 characters. Instead, shorten the variable-length part to 128 characters.

Test Plan

Wiped credentials column and successfully re-ran migration with storage upgrade --force --apply phabricator:20131121.repocredentials.2.mig.php

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped