Page MenuHomePhabricator

Shorten extremely long credential names when migrating them
ClosedPublic

Authored by epriestley on Dec 2 2013, 2:21 PM.
Tags
None
Referenced Files
F15522328: D7677.id.diff
Sun, Apr 20, 7:42 PM
F15522327: D7677.id17335.diff
Sun, Apr 20, 7:42 PM
F15512000: D7677.id17344.diff
Thu, Apr 17, 7:16 AM
F15492661: D7677.id17335.diff
Sat, Apr 12, 4:58 PM
F15483853: D7677.id17344.diff
Wed, Apr 9, 2:51 PM
F15482151: D7677.diff
Wed, Apr 9, 3:24 AM
F15479700: D7677.id.diff
Tue, Apr 8, 8:52 AM
F15476642: D7677.diff
Mon, Apr 7, 8:09 AM
Subscribers

Details

Summary

Fixes T4183. If you have too many repositories sharing the same credential and MySQL is in strict mode, we'll fail a query when trying to write a credential with a name longer than 255 characters. Instead, shorten the variable-length part to 128 characters.

Test Plan

Wiped credentials column and successfully re-ran migration with storage upgrade --force --apply phabricator:20131121.repocredentials.2.mig.php

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped