Page MenuHomePhabricator

Shorten extremely long credential names when migrating them
ClosedPublic

Authored by epriestley on Dec 2 2013, 2:21 PM.
Tags
None
Referenced Files
F14061713: D7677.diff
Mon, Nov 18, 8:12 AM
F14049958: D7677.diff
Thu, Nov 14, 3:33 PM
F14036388: D7677.diff
Sun, Nov 10, 10:04 AM
F14021911: D7677.diff
Wed, Nov 6, 1:50 PM
F13986822: D7677.id17335.diff
Mon, Oct 21, 5:47 AM
F13979235: D7677.id.diff
Oct 19 2024, 3:29 AM
F13970941: D7677.id17344.diff
Oct 17 2024, 10:39 AM
Unknown Object (File)
Oct 1 2024, 8:48 PM
Subscribers

Details

Summary

Fixes T4183. If you have too many repositories sharing the same credential and MySQL is in strict mode, we'll fail a query when trying to write a credential with a name longer than 255 characters. Instead, shorten the variable-length part to 128 characters.

Test Plan

Wiped credentials column and successfully re-ran migration with storage upgrade --force --apply phabricator:20131121.repocredentials.2.mig.php

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped