Page MenuHomePhabricator

Shorten extremely long credential names when migrating them
ClosedPublic

Authored by epriestley on Dec 2 2013, 2:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 4:50 AM
Unknown Object (File)
Sat, Jan 25, 9:38 AM
Unknown Object (File)
Tue, Jan 21, 9:02 AM
Unknown Object (File)
Jan 1 2025, 4:26 PM
Unknown Object (File)
Jan 1 2025, 4:26 PM
Unknown Object (File)
Jan 1 2025, 4:26 PM
Unknown Object (File)
Jan 1 2025, 3:46 PM
Unknown Object (File)
Dec 29 2024, 7:06 PM
Subscribers

Details

Summary

Fixes T4183. If you have too many repositories sharing the same credential and MySQL is in strict mode, we'll fail a query when trying to write a credential with a name longer than 255 characters. Instead, shorten the variable-length part to 128 characters.

Test Plan

Wiped credentials column and successfully re-ran migration with storage upgrade --force --apply phabricator:20131121.repocredentials.2.mig.php

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped