Paths

Table of Contentst

Fix daemons erroring on already closed `STDOUT` and `STDERR`
ClosedPublic
Actions

Authored by richardvanvelzen on Nov 29 2013, 1:07 PM.

Tags

None

Referenced Files

	F13052699: D7674.diff
	Fri, Apr 19, 10:36 AM

	Unknown Object (File)
	Sun, Apr 14, 2:14 AM

	Unknown Object (File)
	Fri, Apr 12, 2:31 PM

	Unknown Object (File)
	Fri, Apr 12, 2:31 PM

	Unknown Object (File)
	Fri, Apr 12, 1:11 PM

	Unknown Object (File)
	Tue, Apr 9, 12:44 AM

	Unknown Object (File)
	Fri, Apr 5, 2:45 AM

	Unknown Object (File)
	Tue, Apr 2, 6:50 AM

Subscribers

Tokens

"The World Burns" token, awarded by epemble.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4177: daemons leave lots of error because of closed STDOUT and STDERR

Commits

rPHU8ebecbf192fa: Fix daemons erroring on already closed `STDOUT` and `STDERR`

Summary

Fixes T4177. This is the only "good" way of not erroring on these lines, because detecting truthyness doesn't always tell you everything.

Test Plan

after changing the lines, tailed the log. Didn't see new errors coming in. Changed the lines back and saw the log growing quite quickly.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley accepted this revision.Nov 29 2013, 2:16 PM

Closed by commit rPHU8ebecbf192fa (authored by Richard van Velzen <rvanvelzen@expert-shops.com>, committed by @epriestley).

Sorry, the git push wasn't FF and I didn't catch it.

Revision Contents
Changeset List

Path

Size

src/

daemon/

PhutilDaemonOverseer.php

8 lines

Diff 17327

View Options

src/daemon/PhutilDaemonOverseer.php

Fix daemons erroring on already closed `STDOUT` and `STDERR`ClosedPublicActions