Page MenuHomePhabricator

Fix Conpherence layout with setup issues
ClosedPublic

Authored by chad on Nov 27 2013, 11:45 PM.
Tags
None
Referenced Files
F13274765: D7669.diff
Fri, May 31, 4:04 AM
F13260190: D7669.diff
Sun, May 26, 11:35 PM
F13244254: D7669.diff
Thu, May 23, 4:39 AM
F13223419: D7669.diff
Sun, May 19, 4:35 AM
Unknown Object (File)
May 3 2024, 9:25 AM
Unknown Object (File)
May 2 2024, 9:37 AM
Unknown Object (File)
Apr 30 2024, 2:40 AM
Unknown Object (File)
Apr 25 2024, 1:09 AM
Tokens
"Yellow Medal" token, awarded by btrahan.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPba76526185df: Fix Conpherence layout with setup issues
Summary

Make Conpherence usable when there is a setup issue as well. Fixes T3427

Test Plan

Test an ongoing thread, create a new thread. Test mobile and tablet layouts.

Diff Detail

Branch
conph-setup-div
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Hmm, I think the thread list doesn't overflow / pick up a scrollbar properly now. I can scroll down the page and have the header vanish:

{F87100}

I guess I didn't check the overloaded cases. And seems like redundant threads continue to be a problem. I wonder if we should just not allow that (hash the participants or something)