Uses edge query to attach TaskPHIDs to commit objects
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP49f3ff0e08f4: Attach TaskPHIDs to commits in diffusion.getcommits
Use conduit to getcommits with attached tasks
Diff Detail
Diff Detail
- Branch
- getcommits-taskphids
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
One simplification inline.
| src/applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php | ||
|---|---|---|
| 278–283 | I believe you can simplify this slightly as: $task_type = PhabricatorEdgeConfig::TYPE_COMMIT_HAS_TASK; // ... $task_phids = $edge_query->getDestinationPHIDs( array($commit['commitPHID']), array($task_type)); | |