If there is no /query in the URL, the default query would be lost when clicking Next, causing the search form to be shown on the second page. This is not so likely to happen on a standard Phabricator installation because the default query is Assigned, and few people will have 100+ tasks assigned.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPbf2f599abb1e: Fix Maniphest Next button not working when default query has 100+ results.
- Go to /maniphest/query/edit/
- Move Open Tasks to the top
- Go to /maniphest/
- Click Next on the bottom right
- See only tasks that are actually open
Diff Detail
Diff Detail
- Branch
- fix-browse-without-query
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
There may be a better and more compact way to fix this, I'm no PHP developer, but this solved the issue here.
Comment Actions
This seems reasonable to me. I might just do something like:
$data = ...
unset($data['before']);
unset($data['after']);
if ($data) {
}...were I writing it myself, but I don't think that's dramatically cleaner.