Improve the performance of phutil_loggable_string()
ClosedPublic
Actions

Authored by epriestley on Nov 26 2013, 1:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 3:36 PM

	Unknown Object (File)
	Fri, Dec 13, 7:44 AM

	Unknown Object (File)
	Sun, Dec 8, 8:06 PM

	Unknown Object (File)
	Dec 6 2024, 4:49 PM

	Unknown Object (File)
	Nov 21 2024, 9:43 PM

	Unknown Object (File)
	Nov 17 2024, 10:07 PM

	Unknown Object (File)
	Nov 14 2024, 4:56 PM

	Unknown Object (File)
	Nov 10 2024, 2:15 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4162: Implement a low-level, high-volume event log for auditing

Commits

rPHU6d5ec28d2e49: Improve the performance of phutil_loggable_string()

Summary

Ref T4162.

Before doing anything character oriented, test if the whole string is fine to print as-is.
Reduce the number of calls to string().

Test Plan

Saw cost drop on profiles.

Diff Detail

Branch

lstr

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Nov 26 2013, 4:57 PM

Closed by commit rPHU6d5ec28d2e49 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

utils/

utils.php

7 lines

Diff 17286

View Options

Improve the performance of phutil_loggable_string()ClosedPublicActions