Improve the performance of phutil_loggable_string()
ClosedPublic
Actions

Authored by epriestley on Nov 26 2013, 1:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 8, 8:06 PM

	Unknown Object (File)
	Fri, Dec 6, 4:49 PM

	Unknown Object (File)
	Thu, Nov 21, 9:43 PM

	Unknown Object (File)
	Sun, Nov 17, 10:07 PM

	Unknown Object (File)
	Thu, Nov 14, 4:56 PM

	Unknown Object (File)
	Nov 10 2024, 2:15 AM

	Unknown Object (File)
	Nov 5 2024, 9:43 PM

	Unknown Object (File)
	Oct 20 2024, 10:01 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4162: Implement a low-level, high-volume event log for auditing

Commits

rPHU6d5ec28d2e49: Improve the performance of phutil_loggable_string()

Summary

Ref T4162.

Before doing anything character oriented, test if the whole string is fine to print as-is.
Reduce the number of calls to string().

Test Plan

Saw cost drop on profiles.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 26 2013, 4:57 PM

Closed by commit rPHU6d5ec28d2e49 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

utils/

utils.php

7 lines

Diff 17298

View Options

Improve the performance of phutil_loggable_string()ClosedPublicActions