Improve the performance of phutil_loggable_string()
ClosedPublic
Actions

Authored by epriestley on Nov 26 2013, 1:33 AM.

Tags

None

Referenced Files

	F15485994: D7656.id17286.diff
	Thu, Apr 10, 4:10 AM

	F15475732: D7656.id17298.diff
	Sun, Apr 6, 10:52 PM

	F15473029: D7656.id.diff
	Sat, Apr 5, 7:03 PM

	F15470432: D7656.diff
	Fri, Apr 4, 10:08 PM

	F15407959: D7656.diff
	Tue, Mar 18, 8:26 PM

	Unknown Object (File)
	Feb 24 2025, 3:05 AM

	Unknown Object (File)
	Feb 4 2025, 5:41 AM

	Unknown Object (File)
	Jan 28 2025, 9:33 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4162: Implement a low-level, high-volume event log for auditing

Commits

rPHU6d5ec28d2e49: Improve the performance of phutil_loggable_string()

Summary

Ref T4162.

Before doing anything character oriented, test if the whole string is fine to print as-is.
Reduce the number of calls to string().

Test Plan

Saw cost drop on profiles.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 26 2013, 4:57 PM

Closed by commit rPHU6d5ec28d2e49 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

utils/

utils.php

7 lines

Diff 17298

View Options

Improve the performance of phutil_loggable_string()ClosedPublicActions