Page MenuHomePhabricator

Normalize the definition of "closed" revision statuses
ClosedPublic

Authored by epriestley on Nov 25 2013, 11:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 4:42 AM
Unknown Object (File)
Tue, Dec 3, 6:26 AM
Unknown Object (File)
Wed, Nov 27, 9:04 AM
Unknown Object (File)
Mon, Nov 25, 6:01 PM
Unknown Object (File)
Fri, Nov 22, 3:22 PM
Unknown Object (File)
Oct 25 2024, 8:43 AM
Unknown Object (File)
Oct 24 2024, 11:08 AM
Unknown Object (File)
Oct 15 2024, 5:13 PM
Subscribers

Details

Summary

Currently, "Closed" and "Abandoned" are treated as "closed". I want to add a flag which treats "Accepted" as "Closed", too, for Asana and other companies who use an Asana-like workflow.

The background here is that their workflow is a bit weird. They basically do audits, but have a lot of things which Diffusion doesn't do well right now. This one change makes Differential fit their workflow fairly well, even though it's an audit workflow.

To prepare for this, normalize the definition of "closed" better. We have a few callsites which explicitly check for "ABANDONED || CLOSED", and normalizing this is cleaner anyway.

Also delete the very old COMMITTED status, which has been obsolete for over a year.

Test Plan

Browsed around most/all of the affected interfaces.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped