Page MenuHomePhabricator

Normalize the definition of "closed" revision statuses

Authored by epriestley on Nov 25 2013, 11:24 PM.
Referenced Files
Unknown Object (File)
Sat, Jun 18, 5:40 PM
Unknown Object (File)
Thu, Jun 16, 12:36 PM
Unknown Object (File)
Mon, Jun 13, 10:27 AM
Unknown Object (File)
Tue, Jun 7, 2:29 AM
Unknown Object (File)
Sep 14 2016, 4:57 PM
Unknown Object (File)
Apr 20 2016, 7:36 AM
Unknown Object (File)
Apr 19 2016, 3:25 PM
Unknown Object (File)
Nov 23 2015, 5:13 AM



Currently, "Closed" and "Abandoned" are treated as "closed". I want to add a flag which treats "Accepted" as "Closed", too, for Asana and other companies who use an Asana-like workflow.

The background here is that their workflow is a bit weird. They basically do audits, but have a lot of things which Diffusion doesn't do well right now. This one change makes Differential fit their workflow fairly well, even though it's an audit workflow.

To prepare for this, normalize the definition of "closed" better. We have a few callsites which explicitly check for "ABANDONED || CLOSED", and normalizing this is cleaner anyway.

Also delete the very old COMMITTED status, which has been obsolete for over a year.

Test Plan

Browsed around most/all of the affected interfaces.

Diff Detail

Lint Passed
Tests Passed