Show SSH user on git-over-ssh repositories and hide both username and password for other repos.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4147: Restore some form of clone URI customization for Diffusion remotes
- Commits
- Restricted Diffusion Commit
rP4910a36563a6: Set reasonable defaults when displaying remote repository URIs.
View repository details page in diffusion, Clone URI should appear with a username (taken from repo config) and any http(s) repos should be without usernames.
Diff Detail
Diff Detail
- Branch
- remote_repo_uri_defaults
- Lint
Lint Errors Severity Location Code Message Error src/applications/auth/controller/PhabricatorEmailTokenController.php:54 PHL1 Unknown Symbol Error src/applications/calendar/view/AphrontCalendarMonthView.php:90 PHL1 Unknown Symbol Error src/applications/conpherence/controller/ConpherenceNotificationPanelController.php:75 PHL1 Unknown Symbol Error src/applications/differential/landing/DifferentialLandingToGitHub.php:85 PHL1 Unknown Symbol Error src/applications/differential/render/DifferentialChangesetHTMLRenderer.php:253 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialAddCommentView.php:189 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialInlineCommentView.php:233 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialLocalCommitsView.php:131 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialRevisionCommentView.php:90 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php:205 PHL1 Unknown Symbol Error src/applications/diffusion/controller/DiffusionCommitController.php:747 PHL1 Unknown Symbol Error src/applications/diffusion/view/DiffusionCommentView.php:142 PHL1 Unknown Symbol Error src/applications/feed/builder/PhabricatorFeedBuilder.php:51 PHL1 Unknown Symbol Error src/applications/feed/controller/PhabricatorFeedDetailController.php:30 PHL1 Unknown Symbol Error src/applications/feed/controller/PhabricatorFeedListController.php:35 PHL1 Unknown Symbol Error src/applications/feed/controller/PhabricatorFeedPublicStreamController.php:28 PHL1 Unknown Symbol Error src/applications/herald/controller/HeraldTranscriptController.php:371 PHL1 Unknown Symbol Error src/applications/maniphest/controller/ManiphestTaskDescriptionPreviewController.php:21 PHL1 Unknown Symbol Error src/applications/maniphest/controller/ManiphestTaskDetailController.php:352 PHL1 Unknown Symbol Error src/applications/notification/controller/PhabricatorNotificationListController.php:48 PHL1 Unknown Symbol Error src/applications/notification/controller/PhabricatorNotificationPanelController.php:23 PHL1 Unknown Symbol Error src/applications/people/controller/PhabricatorPeopleProfileController.php:130 PHL1 Unknown Symbol Error src/applications/phame/controller/post/PhamePostEditController.php:146 PHL1 Unknown Symbol Error src/applications/phame/controller/post/PhamePostPreviewController.php:26 PHL1 Unknown Symbol Error src/applications/phriction/storage/PhrictionContent.php:78 PHL1 Unknown Symbol - Unit
Tests Passed
Event Timeline
Comment Actions
Update libphutil to clear that lint.
| src/applications/repository/storage/PhabricatorRepository.php | ||
|---|---|---|
| 584 | I think $this->shouldUseSSH() is a better check. We want to show username data for explicit SSH Git, too, e.g.: ssh://git@github.com/blah/blah | |