Cascade DarkConsole query plan analyzer to Ajax requests
ClosedPublic
Actions

Authored by epriestley on Nov 18 2013, 9:45 PM.

Tags

None

Referenced Files

	F14376398: D7601.diff
	Fri, Dec 20, 11:44 PM

	Unknown Object (File)
	Sat, Nov 30, 4:50 AM

	Unknown Object (File)
	Fri, Nov 29, 3:54 AM

	Unknown Object (File)
	Fri, Nov 29, 3:54 AM

	Unknown Object (File)
	Fri, Nov 29, 3:49 AM

	Unknown Object (File)
	Fri, Nov 29, 3:43 AM

	Unknown Object (File)
	Nov 20 2024, 9:39 PM

	Unknown Object (File)
	Nov 20 2024, 2:28 PM

View All Files

Subscribers

aran

Tokens

"Like" token, awarded by richardvanvelzen."Like" token, awarded by tomknig.

Details

Reviewers

btrahan

Maniphest Tasks

T4123: Cascade "Analyze Query Plans" in to subrequests

Commits

Restricted Diffusion Commit
rP4aba4ddb2c93: Cascade DarkConsole query plan analyzer to Ajax requests

Summary

Fixes T4123. If you click "Profile" on a page, we already profile all the ajax requests it generates. Do the same for "Analyze Query Plans".

Test Plan

Viewed a page with Ajax requests using "Analyze Query Plans", and not using "Analyze Query Plans".

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 19 2013, 5:53 PM

Closed by commit rP4aba4ddb2c93 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

aphront/

console/

plugin/

DarkConsoleServicesPlugin.php

23 lines

view/

page/

PhabricatorStandardPageView.php

3 lines

Diff 17170

View Options

src/aphront/console/plugin/DarkConsoleServicesPlugin.php