Page MenuHomePhabricator

Improve performacne of PhutilSymbolLoader
ClosedPublic

Authored by epriestley on Nov 14 2013, 12:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 3:22 AM
Unknown Object (File)
Wed, May 1, 7:35 PM
Unknown Object (File)
Wed, May 1, 5:59 PM
Unknown Object (File)
Mon, Apr 29, 2:40 PM
Unknown Object (File)
Wed, Apr 24, 10:12 PM
Unknown Object (File)
Fri, Apr 19, 4:36 AM
Unknown Object (File)
Thu, Apr 11, 8:17 AM
Unknown Object (File)
Feb 14 2024, 3:33 PM
Subscribers
Tokens
"Love" token, awarded by nmalcolm.

Details

Summary

Currently, we build way more symbols than we need to when doing loadObjects(). Instead, select only the candidates we know will match the request.

Test Plan

650ms -> 380ms on Differential revision page, which hits this more than it probably should.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped