Page MenuHomePhabricator

Improve performacne of PhutilSymbolLoader
ClosedPublic

Authored by epriestley on Nov 14 2013, 12:26 AM.
Tags
None
Referenced Files
F18815503: D7584.diff
Tue, Oct 21, 2:28 AM
F18811243: D7584.id17120.diff
Mon, Oct 20, 2:09 AM
F18739124: D7584.id.diff
Wed, Oct 1, 7:53 PM
F18732876: D7584.diff
Tue, Sep 30, 8:19 PM
F18624480: D7584.diff
Sep 15 2025, 8:09 PM
F18588145: D7584.diff
Sep 11 2025, 11:24 PM
F18440659: D7584.id.diff
Aug 31 2025, 3:54 PM
F18423568: D7584.diff
Aug 30 2025, 7:47 PM
Subscribers
Tokens
"Love" token, awarded by nmalcolm.

Details

Summary

Currently, we build way more symbols than we need to when doing loadObjects(). Instead, select only the candidates we know will match the request.

Test Plan

650ms -> 380ms on Differential revision page, which hits this more than it probably should.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped