Page MenuHomePhabricator

Improve performacne of PhutilSymbolLoader
ClosedPublic

Authored by epriestley on Nov 14 2013, 12:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2025, 1:01 PM
Unknown Object (File)
May 31 2025, 11:36 PM
Unknown Object (File)
May 29 2025, 7:34 PM
Unknown Object (File)
May 7 2025, 3:18 PM
Unknown Object (File)
Apr 28 2025, 4:51 PM
Unknown Object (File)
Apr 26 2025, 4:08 PM
Unknown Object (File)
Apr 25 2025, 7:47 PM
Unknown Object (File)
Apr 16 2025, 11:50 PM
Subscribers
Tokens
"Love" token, awarded by nmalcolm.

Details

Summary

Currently, we build way more symbols than we need to when doing loadObjects(). Instead, select only the candidates we know will match the request.

Test Plan

650ms -> 380ms on Differential revision page, which hits this more than it probably should.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped