Page MenuHomePhabricator

Respect "can edit username" in registration UI
ClosedPublic

Authored by epriestley on Nov 13 2013, 6:26 AM.
Tags
None
Referenced Files
F14015642: D7577.diff
Sun, Nov 3, 11:09 PM
F13984350: D7577.diff
Sun, Oct 20, 12:44 PM
F13978836: D7577.id17108.diff
Sat, Oct 19, 1:15 AM
Unknown Object (File)
Sep 24 2024, 3:15 PM
Unknown Object (File)
Sep 20 2024, 4:32 AM
Unknown Object (File)
Sep 12 2024, 9:59 PM
Unknown Object (File)
Sep 12 2024, 9:58 PM
Unknown Object (File)
Sep 12 2024, 9:58 PM
Subscribers

Details

Reviewers
btrahan
datr
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPfb6e38548b0c: Respect "can edit username" in registration UI
Summary

Fixes T3741. The flag is respected in terms of actually creating the account, but the UI is a bit unclear.

This can never occur naturally, but installs can register an event which locks it.

Test Plan

Artificially locked it, verified I got more reasonable UI;

{F81282}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Pretty much matches what I've done to my patched copy. Looks good.

Thanks! Sorry this took so long to get to, I thought it was a little more involved than it actually was.