Page MenuHomePhabricator

Roadblock users trying to register with external accounts that have invalid emails
ClosedPublic

Authored by epriestley on Nov 12 2013, 7:58 PM.
Tags
None
Referenced Files
F15702599: D7571.diff
Wed, May 28, 8:47 PM
Unknown Object (File)
Wed, May 7, 11:36 PM
Unknown Object (File)
Mar 26 2025, 8:51 PM
Unknown Object (File)
Mar 26 2025, 8:51 PM
Unknown Object (File)
Mar 16 2025, 1:53 PM
Unknown Object (File)
Feb 24 2025, 3:03 AM
Unknown Object (File)
Feb 9 2025, 5:28 PM
Unknown Object (File)
Feb 8 2025, 11:31 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPcd73fe78db36: Roadblock users trying to register with external accounts that have invalid…
Summary

Ref T3472. Currently, if an install only allows "@mycompany.com" emails and you try to register with an "@personal.com" account, we let you pick an "@mycompany.com" address instead. This is secure: you still have to verify the email. However, it defies user expectation -- it's somewhat confusing that we let you register. Instead, provide a hard roadblock.

(These accounts can still be linked, just not used for registration.)

Test Plan

See screenshot.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/auth/controller/PhabricatorAuthRegisterController.php
71–73

Oh, maybe something that you can link the account once you register?

src/applications/auth/controller/PhabricatorAuthRegisterController.php
71–73

I worry that users have a tenuous understanding of what "linking accounts" means, and am hesitant to put more words here than necessary. If people show up with support questions about this, that would indicate to me that it might be useful to provide more details, though.