Page MenuHomePhabricator

Roadblock users trying to register with external accounts that have invalid emails
ClosedPublic

Authored by epriestley on Nov 12 2013, 7:58 PM.
Tags
None
Referenced Files
F14027243: D7571.diff
Fri, Nov 8, 6:03 AM
F14005157: D7571.id17092.diff
Sun, Oct 27, 8:08 AM
F13963188: D7571.diff
Tue, Oct 15, 2:26 PM
F13963178: D7571.id.diff
Tue, Oct 15, 2:23 PM
F13963173: D7571.id17090.diff
Tue, Oct 15, 2:22 PM
F13963171: D7571.id17092.diff
Tue, Oct 15, 2:20 PM
Unknown Object (File)
Sep 22 2024, 8:13 AM
Unknown Object (File)
Sep 12 2024, 9:54 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPcd73fe78db36: Roadblock users trying to register with external accounts that have invalid…
Summary

Ref T3472. Currently, if an install only allows "@mycompany.com" emails and you try to register with an "@personal.com" account, we let you pick an "@mycompany.com" address instead. This is secure: you still have to verify the email. However, it defies user expectation -- it's somewhat confusing that we let you register. Instead, provide a hard roadblock.

(These accounts can still be linked, just not used for registration.)

Test Plan

See screenshot.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/auth/controller/PhabricatorAuthRegisterController.php
71–73

Oh, maybe something that you can link the account once you register?

src/applications/auth/controller/PhabricatorAuthRegisterController.php
71–73

I worry that users have a tenuous understanding of what "linking accounts" means, and am hesitant to put more words here than necessary. If people show up with support questions about this, that would indicate to me that it might be useful to provide more details, though.