Fix incorrect check for CAN_EDIT in macro enable/disable controller
ClosedPublic
Actions

Authored by epriestley on Nov 10 2013, 12:30 AM.

Tags

None

Referenced Files

	F18583821: D7550.diff
	Thu, Sep 11, 11:16 AM

	F18084043: D7550.id17038.diff
	Aug 5 2025, 1:27 PM

	F17986474: D7550.id17039.diff
	Aug 1 2025, 9:44 PM

	F17944619: D7550.id.diff
	Jul 31 2025, 10:43 AM

	F17931822: D7550.diff
	Jul 30 2025, 7:29 PM

	Unknown Object (File)
	May 27 2025, 5:03 PM

	Unknown Object (File)
	May 27 2025, 5:01 PM

	Unknown Object (File)
	May 20 2025, 8:10 PM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Commits

Restricted Diffusion Commit
rP5bb646a838bf: Fix incorrect check for CAN_EDIT in macro enable/disable controller

Summary

This CAN_EDIT capability doesn't exist. PhabricatorMacroCapabilityManage::CAPABILITY (checked on line 15) is used instead.

Test Plan

Disabled, then re-enabled a macro.

Diff Detail

Branch

mdisab

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Tested this and it works.

Closed by commit rP5bb646a838bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroDisableController.php

5 lines

Diff 17038

View Options

src/applications/macro/controller/PhabricatorMacroDisableController.php

Fix incorrect check for CAN_EDIT in macro enable/disable controllerClosedPublicActions