Fix incorrect check for CAN_EDIT in macro enable/disable controller
ClosedPublic
Actions

Authored by epriestley on Nov 10 2013, 12:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 20, 8:10 PM

	Unknown Object (File)
	Mon, May 19, 9:54 AM

	Unknown Object (File)
	Sun, May 18, 7:21 PM

	Unknown Object (File)
	Wed, May 7, 9:21 PM

	Unknown Object (File)
	Sun, Apr 27, 3:47 AM

	Unknown Object (File)
	Sat, Apr 26, 4:02 PM

	Unknown Object (File)
	Apr 8 2025, 6:44 PM

	Unknown Object (File)
	Apr 8 2025, 3:57 PM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Commits

Restricted Diffusion Commit
rP5bb646a838bf: Fix incorrect check for CAN_EDIT in macro enable/disable controller

Summary

This CAN_EDIT capability doesn't exist. PhabricatorMacroCapabilityManage::CAPABILITY (checked on line 15) is used instead.

Test Plan

Disabled, then re-enabled a macro.

Diff Detail

Branch

mdisab

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Tested this and it works.

Closed by commit rP5bb646a838bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroDisableController.php

5 lines

Diff 17038

View Options

src/applications/macro/controller/PhabricatorMacroDisableController.php

Fix incorrect check for CAN_EDIT in macro enable/disable controllerClosedPublicActions