Fix incorrect check for CAN_EDIT in macro enable/disable controller
ClosedPublic
Actions

Authored by epriestley on Nov 10 2013, 12:30 AM.

Tags

None

Referenced Files

	F15459978: D7550.diff
	Mon, Mar 31, 6:49 PM

	F15442020: D7550.id17039.diff
	Wed, Mar 26, 9:00 PM

	F15442006: D7550.diff
	Wed, Mar 26, 8:58 PM

	F15439959: D7550.id.diff
	Wed, Mar 26, 10:32 AM

	F15404014: D7550.id.diff
	Tue, Mar 18, 5:52 AM

	F15348055: D7550.diff
	Mon, Mar 10, 2:11 PM

	F15339436: D7550.diff
	Sun, Mar 9, 2:45 PM

	Unknown Object (File)
	Feb 25 2025, 1:02 PM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Commits

Restricted Diffusion Commit
rP5bb646a838bf: Fix incorrect check for CAN_EDIT in macro enable/disable controller

Summary

This CAN_EDIT capability doesn't exist. PhabricatorMacroCapabilityManage::CAPABILITY (checked on line 15) is used instead.

Test Plan

Disabled, then re-enabled a macro.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Tested this and it works.

Closed by commit rP5bb646a838bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroDisableController.php

5 lines

Diff 17039

View Options

src/applications/macro/controller/PhabricatorMacroDisableController.php

Fix incorrect check for CAN_EDIT in macro enable/disable controllerClosedPublicActions