Fix incorrect check for CAN_EDIT in macro enable/disable controller
ClosedPublic
Actions

Authored by epriestley on Nov 10 2013, 12:30 AM.

Tags

None

Referenced Files

	F19609171: D7550.id17039.diff
	Tue, Feb 3, 1:29 PM

	F19548010: D7550.id17039.diff
	Mon, Jan 26, 5:34 PM

	F18852730: D7550.diff
	Oct 31 2025, 11:34 AM

	F18773283: D7550.id.diff
	Oct 9 2025, 8:43 AM

	F18771423: D7550.diff
	Oct 8 2025, 7:34 PM

	F18601846: D7550.diff
	Sep 13 2025, 1:36 PM

	F18590221: D7550.id17039.diff
	Sep 12 2025, 5:33 AM

	F18588435: D7550.diff
	Sep 12 2025, 12:17 AM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Commits

Restricted Diffusion Commit
rP5bb646a838bf: Fix incorrect check for CAN_EDIT in macro enable/disable controller

Summary

This CAN_EDIT capability doesn't exist. PhabricatorMacroCapabilityManage::CAPABILITY (checked on line 15) is used instead.

Test Plan

Disabled, then re-enabled a macro.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Tested this and it works.

Closed by commit rP5bb646a838bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroDisableController.php

5 lines

Diff 17039

View Options

src/applications/macro/controller/PhabricatorMacroDisableController.php

Fix incorrect check for CAN_EDIT in macro enable/disable controllerClosedPublicActions