Fix incorrect check for CAN_EDIT in macro enable/disable controller
ClosedPublic
Actions

Authored by epriestley on Nov 10 2013, 12:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 5, 1:37 PM

	Unknown Object (File)
	Jun 5 2026, 9:30 AM

	Unknown Object (File)
	Apr 18 2026, 5:13 AM

	Unknown Object (File)
	Mar 14 2026, 2:31 PM

	Unknown Object (File)
	Mar 13 2026, 2:25 AM

	Unknown Object (File)
	Mar 5 2026, 1:06 AM

	Unknown Object (File)
	Feb 17 2026, 4:07 PM

	Unknown Object (File)
	Feb 11 2026, 4:08 AM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Commits

Restricted Diffusion Commit
rP5bb646a838bf: Fix incorrect check for CAN_EDIT in macro enable/disable controller

Summary

This CAN_EDIT capability doesn't exist. PhabricatorMacroCapabilityManage::CAPABILITY (checked on line 15) is used instead.

Test Plan

Disabled, then re-enabled a macro.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Tested this and it works.

Closed by commit rP5bb646a838bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroDisableController.php

5 lines

Diff 17039

View Options

src/applications/macro/controller/PhabricatorMacroDisableController.php

Fix incorrect check for CAN_EDIT in macro enable/disable controllerClosedPublicActions