Fix incorrect check for CAN_EDIT in macro enable/disable controller
ClosedPublic
Actions

Authored by epriestley on Nov 10 2013, 12:30 AM.

Tags

None

Referenced Files

	F15549092: D7550.id17039.diff
	Sun, Apr 27, 3:47 AM

	F15546533: D7550.diff
	Sat, Apr 26, 4:02 PM

	F15481158: D7550.id17039.diff
	Tue, Apr 8, 6:44 PM

	F15480716: D7550.id17038.diff
	Tue, Apr 8, 3:57 PM

	F15459978: D7550.diff
	Mon, Mar 31, 6:49 PM

	F15442020: D7550.id17039.diff
	Mar 26 2025, 9:00 PM

	F15442006: D7550.diff
	Mar 26 2025, 8:58 PM

	F15439959: D7550.id.diff
	Mar 26 2025, 10:32 AM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Commits

Restricted Diffusion Commit
rP5bb646a838bf: Fix incorrect check for CAN_EDIT in macro enable/disable controller

Summary

This CAN_EDIT capability doesn't exist. PhabricatorMacroCapabilityManage::CAPABILITY (checked on line 15) is used instead.

Test Plan

Disabled, then re-enabled a macro.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Tested this and it works.

Closed by commit rP5bb646a838bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroDisableController.php

5 lines

Diff 17039

View Options

src/applications/macro/controller/PhabricatorMacroDisableController.php

Fix incorrect check for CAN_EDIT in macro enable/disable controllerClosedPublicActions