Page MenuHomePhabricator
Differential D7549

Replace some hsprintf() by phutil_tag()
ClosedPublic
Actions

Authored by vrana on Nov 9 2013, 7:08 PM.
Tags
None
Referenced Files
F14460956: D7549.diff
Fri, Dec 27, 8:39 AM
F14448331: D7549.diff
Thu, Dec 26, 4:34 PM
Unknown Object (File)
Mon, Dec 23, 6:23 AM
Unknown Object (File)
Mon, Dec 23, 6:23 AM
Unknown Object (File)
Mon, Dec 23, 5:51 AM
Unknown Object (File)
Wed, Dec 11, 7:44 PM
Unknown Object (File)
Sat, Dec 7, 5:03 PM
Unknown Object (File)
Fri, Nov 29, 5:20 AM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPa29b5b070f5a: Replace some hsprintf() by phutil_tag()
Test Plan

Looked at a diff with inline comment.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley accepted this revision.Nov 9 2013, 11:08 PM

These all look correct to me. Thanks!

vrana closed this revision.Nov 11 2013, 5:23 PM

Closed by commit rPa29b5b070f5a (authored by @vrana).

vrana added a comment.Nov 13 2013, 8:55 PM

The segfault mentioned in unit test excuse occured in getNextObjectSeed(), it was because of the operator extension. All the tests pass with this extension disabled.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
11 lines
4 lines
provider/
8 lines
4 lines
base/
controller/
5 lines
calendar/
controller/
2 lines
view/
78 lines
conduit/
controller/
5 lines
query/
5 lines
config/
controller/
32 lines
conpherence/
controller/
4 lines
countdown/
controller/
2 lines
view/
43 lines
differential/
controller/
5 lines
2 lines
render/
34 lines
14 lines
105 lines
view/
17 lines
28 lines
49 lines
26 lines
51 lines
10 lines
11 lines
36 lines
diffusion/
controller/
36 lines
31 lines
16 lines
view/
8 lines
6 lines
feed/
builder/
4 lines
controller/
4 lines
4 lines
3 lines
story/
4 lines
harbormaster/
view/
20 lines
herald/
controller/
4 lines
65 lines
maniphest/
controller/
6 lines
4 lines
15 lines
notification/
controller/
8 lines
4 lines
owners/
controller/
4 lines
people/
controller/
17 lines
6 lines
phame/
controller/
post/
19 lines
2 lines
skins/
2 lines
phpast/
controller/
17 lines
phriction/
controller/
16 lines
2 lines
storage/
18 lines
project/
controller/
34 lines
repository/
controller/
5 lines
search/
controller/
19 lines
settings/
panel/
13 lines
2 lines
14 lines
system/
2 lines
webroot/
13 lines

Diff 17052

View Options

src/applications/auth/controller/PhabricatorEmailTokenController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorMustVerifyEmailController.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderLDAP.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuthFacebook.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarBrowseController.php

Loading...
View Options

src/applications/calendar/view/AphrontCalendarMonthView.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownDeleteController.php

Loading...
View Options

src/applications/countdown/view/PhabricatorCountdownView.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionLandController.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

src/applications/differential/view/DifferentialAddCommentView.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

src/applications/differential/view/DifferentialDiffTableOfContentsView.php

Loading...
View Options

src/applications/differential/view/DifferentialInlineCommentEditView.php

Loading...
View Options

src/applications/differential/view/DifferentialInlineCommentView.php

Loading...
View Options

src/applications/differential/view/DifferentialLocalCommitsView.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionCommentView.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintDetailsController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionBrowseTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommentView.php

Loading...
View Options

src/applications/feed/builder/PhabricatorFeedBuilder.php

Loading...
View Options

src/applications/feed/controller/PhabricatorFeedDetailController.php

Loading...
View Options

src/applications/feed/controller/PhabricatorFeedListController.php

Loading...
View Options

src/applications/feed/controller/PhabricatorFeedPublicStreamController.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryCommit.php

Loading...
View Options

src/applications/harbormaster/view/ShellLogView.php

Loading...
View Options

src/applications/herald/controller/HeraldTestConsoleController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDescriptionPreviewController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationListController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDeleteController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostPreviewController.php

Loading...
View Options

src/applications/phame/skins/PhameBasicBlogSkin.php

Loading...
View Options

src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionNewController.php

Loading...
View Options

src/applications/phriction/storage/PhrictionContent.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelConduit.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php

Loading...
View Options

src/applications/system/PhabricatorDebugController.php

Loading...
View Options

webroot/index.php

Loading...
Phabricator · Built by Phacility