This is one of the rare moments where unit tests for views would be useful.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rPfd8d9ff0d689: Replace some hsprintf() with phutil_tag() and phutil_tag_div() Depends on D7545.
Diff Detail
Diff Detail
- Branch
- hsprintf
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
Comment Actions
These all look correct to me. Thanks for doing this!
| src/infrastructure/diff/PhabricatorInlineCommentController.php | ||
|---|---|---|
| 74–75 | The <p> can be omitted from single paragraphs in dialog and error bodies. | |