Replace some hsprintf() with phutil_tag()
ClosedPublic
Actions

Authored by vrana on Nov 8 2013, 5:56 PM.

Tags

None

Referenced Files

	F13994918: D7533.id17022.diff
	Wed, Oct 23, 9:26 AM

	Unknown Object (File)
	Sun, Oct 13, 9:03 PM

	Unknown Object (File)
	Sun, Oct 13, 6:10 AM

	Unknown Object (File)
	Oct 3 2024, 9:51 PM

	Unknown Object (File)
	Oct 3 2024, 9:48 PM

	Unknown Object (File)
	Oct 3 2024, 9:47 PM

	Unknown Object (File)
	Oct 3 2024, 9:45 PM

	Unknown Object (File)
	Sep 26 2024, 12:14 PM

Subscribers

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPaca621e21f9c: Replace some hsprintf() with phutil_tag()

Summary

I just want to make sure that this is the style we want.
It seems less readable to me in some cases.

Test Plan

Looked at DarkConsole with errors.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vrana added inline comments.Nov 8 2013, 5:59 PM

src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
47–60	This is untranslatable with current `pht()`.

I think this code (which isn't using standard UI classes) is some of the least-readable with phutil_tag(), which is partly why it's hsprintf() in the first place. The next time DarkConsole gets some design work done we'll probably simplify some of this (e.g., remove inline style attributes), which should make it a bit more readable.