I just want to make sure that this is the style we want.
It seems less readable to me in some cases.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rPaca621e21f9c: Replace some hsprintf() with phutil_tag()
Looked at DarkConsole with errors.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/aphront/console/plugin/DarkConsoleXHProfPlugin.php | ||
|---|---|---|
| 47–60 | This is untranslatable with current pht(). | |
Comment Actions
I think this code (which isn't using standard UI classes) is some of the least-readable with phutil_tag(), which is partly why it's hsprintf() in the first place. The next time DarkConsole gets some design work done we'll probably simplify some of this (e.g., remove inline style attributes), which should make it a bit more readable.