Replace some hsprintf() with phutil_tag()
ClosedPublic
Actions

Authored by vrana on Nov 8 2013, 5:56 PM.

Tags

None

Referenced Files

	F18821710: D7533.diff
	Thu, Oct 23, 1:22 AM

	F18766455: D7533.id.diff
	Tue, Oct 7, 4:47 PM

	F18760062: D7533.diff
	Mon, Oct 6, 7:47 AM

	F18626845: D7533.id16991.diff
	Sep 16 2025, 2:38 AM

	F18613669: D7533.diff
	Sep 14 2025, 11:22 AM

	F18600208: D7533.diff
	Sep 13 2025, 9:13 AM

	F18585241: D7533.id16991.diff
	Sep 11 2025, 2:46 PM

	F18463664: D7533.diff
	Sep 2 2025, 1:48 AM

Subscribers

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPaca621e21f9c: Replace some hsprintf() with phutil_tag()

Summary

I just want to make sure that this is the style we want.
It seems less readable to me in some cases.

Test Plan

Looked at DarkConsole with errors.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vrana added inline comments.Nov 8 2013, 5:59 PM

src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
47–60	This is untranslatable with current `pht()`.

I think this code (which isn't using standard UI classes) is some of the least-readable with phutil_tag(), which is partly why it's hsprintf() in the first place. The next time DarkConsole gets some design work done we'll probably simplify some of this (e.g., remove inline style attributes), which should make it a bit more readable.