Tighten a regular expression in `repository.create`
ClosedPublic
Actions

Authored by epriestley on Nov 8 2013, 4:01 PM.

Tags

None

Referenced Files

	F15532011: D7531.id16988.diff
	Wed, Apr 23, 2:11 PM

	F15529568: D7531.id16993.diff
	Tue, Apr 22, 8:53 PM

	F15517243: D7531.diff
	Sat, Apr 19, 1:06 AM

	F15515315: D7531.id.diff
	Fri, Apr 18, 9:32 AM

	F15512828: D7531.diff
	Thu, Apr 17, 2:14 PM

	F15505620: D7531.diff
	Tue, Apr 15, 4:28 AM

	F15450933: D7531.id.diff
	Fri, Mar 28, 7:11 PM

	F15433328: D7531.id16993.diff
	Mon, Mar 24, 10:37 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP1c73d6cd067a: Tighten a regular expression in `repository.create`

Summary

See https://github.com/facebook/phabricator/issues/433. We were missing a "^" here.

This should be moved over to transactions soon and then we can get rid of the duplication. :/

Test Plan

Tried to create a repository with callsign "9X", got a helpful error about "ALL UPPERCASE LETTERS".

Diff Detail

Branch

rcreate

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Nov 8 2013, 7:01 PM

Closed by commit rP1c73d6cd067a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

conduit/

ConduitAPI_repository_create_Method.php

2 lines

Diff 16988

View Options

src/applications/repository/conduit/ConduitAPI_repository_create_Method.php

Tighten a regular expression in `repository.create`ClosedPublicActions