Tighten a regular expression in `repository.create`
ClosedPublic
Actions

Authored by epriestley on Nov 8 2013, 4:01 PM.

Tags

None

Referenced Files

	F19587872: D7531.id16993.diff
	Mon, Feb 2, 8:02 AM

	F19506710: D7531.id16988.diff
	Fri, Jan 9, 4:51 PM

	F19503782: D7531.id16993.diff
	Fri, Jan 9, 1:43 AM

	F19503781: D7531.id16988.diff
	Fri, Jan 9, 1:43 AM

	F19503780: D7531.id.diff
	Fri, Jan 9, 1:43 AM

	F19379652: D7531.id.diff
	Dec 26 2025, 10:20 PM

	F19100052: D7531.id16988.diff
	Dec 4 2025, 10:05 PM

	F19056830: D7531.diff
	Nov 28 2025, 8:42 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP1c73d6cd067a: Tighten a regular expression in `repository.create`

Summary

See https://github.com/facebook/phabricator/issues/433. We were missing a "^" here.

This should be moved over to transactions soon and then we can get rid of the duplication. :/

Test Plan

Tried to create a repository with callsign "9X", got a helpful error about "ALL UPPERCASE LETTERS".

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 8 2013, 7:01 PM

Closed by commit rP1c73d6cd067a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

conduit/

ConduitAPI_repository_create_Method.php

2 lines

Diff 16993

View Options

src/applications/repository/conduit/ConduitAPI_repository_create_Method.php

Tighten a regular expression in `repository.create`ClosedPublicActions