Tighten a regular expression in `repository.create`
ClosedPublic
Actions

Authored by epriestley on Nov 8 2013, 4:01 PM.

Tags

None

Referenced Files

	F13995476: D7531.id16988.diff
	Wed, Oct 23, 1:10 PM

	F13985066: D7531.id16988.diff
	Sun, Oct 20, 5:52 PM

	F13985001: D7531.id16993.diff
	Sun, Oct 20, 5:27 PM

	F13984933: D7531.id16988.diff
	Sun, Oct 20, 5:01 PM

	F13984895: D7531.id.diff
	Sun, Oct 20, 4:43 PM

	F13984885: D7531.diff
	Sun, Oct 20, 4:40 PM

	F13984881: D7531.id16993.diff
	Sun, Oct 20, 4:37 PM

	F13984870: D7531.id.diff
	Sun, Oct 20, 4:34 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP1c73d6cd067a: Tighten a regular expression in `repository.create`

Summary

See https://github.com/facebook/phabricator/issues/433. We were missing a "^" here.

This should be moved over to transactions soon and then we can get rid of the duplication. :/

Test Plan

Tried to create a repository with callsign "9X", got a helpful error about "ALL UPPERCASE LETTERS".

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 8 2013, 7:01 PM

Closed by commit rP1c73d6cd067a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

conduit/

ConduitAPI_repository_create_Method.php

2 lines

Diff 16993

View Options

src/applications/repository/conduit/ConduitAPI_repository_create_Method.php

Tighten a regular expression in `repository.create`ClosedPublicActions