Tighten a regular expression in `repository.create`
ClosedPublic
Actions

Authored by epriestley on Nov 8 2013, 4:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 12:44 AM

	Unknown Object (File)
	Wed, Dec 18, 2:53 AM

	Unknown Object (File)
	Thu, Dec 12, 4:50 AM

	Unknown Object (File)
	Sat, Dec 7, 1:58 PM

	Unknown Object (File)
	Fri, Dec 6, 2:46 PM

	Unknown Object (File)
	Fri, Dec 6, 3:33 AM

	Unknown Object (File)
	Wed, Dec 4, 12:54 PM

	Unknown Object (File)
	Wed, Dec 4, 12:54 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP1c73d6cd067a: Tighten a regular expression in `repository.create`

Summary

See https://github.com/facebook/phabricator/issues/433. We were missing a "^" here.

This should be moved over to transactions soon and then we can get rid of the duplication. :/

Test Plan

Tried to create a repository with callsign "9X", got a helpful error about "ALL UPPERCASE LETTERS".

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 8 2013, 7:01 PM

Closed by commit rP1c73d6cd067a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

conduit/

ConduitAPI_repository_create_Method.php

2 lines

Diff 16993

View Options

src/applications/repository/conduit/ConduitAPI_repository_create_Method.php

Tighten a regular expression in `repository.create`ClosedPublicActions