Allow Herald's "Reviewers" field to select project reviewers
ClosedPublic
Actions

Authored by epriestley on Nov 7 2013, 7:03 PM.

Tags

None

Referenced Files

	F19154424: D7526.id16971.diff
	Thu, Dec 11, 3:09 PM

	F19153151: D7526.diff
	Thu, Dec 11, 7:47 AM

	F19152427: D7526.id16971.diff
	Thu, Dec 11, 2:48 AM

	F19080847: D7526.diff
	Dec 2 2025, 3:02 AM

	F19051437: D7526.diff
	Nov 28 2025, 1:08 AM

	F18915314: D7526.diff
	Nov 9 2025, 7:38 AM

	F18864796: D7526.id16971.diff
	Nov 3 2025, 8:45 AM

	F18829875: D7526.diff
	Oct 25 2025, 1:51 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP038f5323c017: Allow Herald's "Reviewers" field to select project reviewers

Summary

The "Reviewers" condition in Differential Revision rules has the wrong typeahead and can't select projects, but should be able to.

Test Plan

{F79273}

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 7 2013, 7:23 PM

Closed by commit rP038f5323c017 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

2 lines

Diff 16972

View Options

src/applications/herald/adapter/HeraldAdapter.php

Allow Herald's "Reviewers" field to select project reviewersClosedPublicActions