Differential D7502
Make the buildables list a little nicer. Authored by hach-que on Nov 5 2013, 8:56 AM. Tags None Referenced Files
Subscribers
Details
Depends on D7501. This just renders the buildable's actual object name onto the list, so you can see at a glance what the buildable represents. I'd like to also pull across a list of builds of this buildable and change the bar color, but I'm not quite sure how to do that in the search architecture without N+1 querying. Looked at the buildable list and it looked like this: {F78555}
Diff Detail
Event TimelineComment Actions For the status, maybe we just update the top-level status and read out of it here to color the bar? e.g., WHATEVER = green, WHO_KNOWS = blue, EHHHH = red, etc. Comment Actions I'm not a fan of the top-level status as a field in the DB; I think it's much better as a calculated field. The reasoning for this is that there's lots of areas where a top-level status needs to be considered; e.g. whenever I add, update or delete a new build I need to update the buildable's status as well, which might not be as easy as it seems. The other aspect is that it provides no details; I'd be much more interested in "3 passed, 1 failed" than "Partial success" as information on the screen. Comment Actions We could start with adding needBuilds() to the query and denormalize later if it's a performance issue. This avoids N+1 stuff. Since Builds always load their Buildables for policy checks, this should happen in didFilterPage() so that the subquery can read the Buildables from cache. I can shoot you a diff for this, it's a touch awkward. |