This adds support for a Conduit method to process Remarkup content in bulk. It also updates the getEngineContexts methods to support any missing contexts.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4046: Support processing remarkup in bulk via Conduit
- Commits
- Restricted Diffusion Commit
rP10a9f6501fd2: Support processing Remarkup in bulk with `remarkup.processbulk` Conduit method
Ran the command and processed a few sets of text.
Diff Detail
Diff Detail
- Branch
- remarkup-bulk
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
Can we just make remarkup.process do this instead? The method is marked "Unstable", and I'd rather not have strictly inferior/obsolete methods.
Comment Actions
D7383 has some pointers on improving the pipelining here if you want to pursue that at some point. Particularly, this isn't cacheable, so performance should improve dramatically for blocks including, e.g., code blocks or interpreter calls if this gets upgraded to use OneOff at some point.
Comment Actions
Generally we do the caching at the client side so we don't have to make the call to remarkup.process if we already know what it results in, so I don't think it'll be a big issue.