Tags

None

Referenced Files

	F17893595: D7467.id.diff
	Tue, Jul 29, 5:10 AM

	F17870216: D7467.diff
	Mon, Jul 28, 1:29 PM

	Unknown Object (File)
	Jun 7 2025, 3:02 AM

	Unknown Object (File)
	May 9 2025, 12:13 AM

	Unknown Object (File)
	May 8 2025, 1:37 AM

	Unknown Object (File)
	Apr 26 2025, 2:32 PM

	Unknown Object (File)
	Apr 13 2025, 1:30 PM

	Unknown Object (File)
	Apr 11 2025, 9:45 AM

View All Files

Subscribers

aran

Tokens

"Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers

btrahan
chad

Maniphest Tasks

Restricted Maniphest Task
Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP40b081820770: Show additional status information during repository import

Summary

Ref T2350. Fixes T2231.

Adds log flags around discovery.
Adds message flags for "needs update". This is basically an out-of-band hint to the daemons that a repository should be pulled sooner than normal. We set the flag when users push a revision, and expose a Conduit method that arc land will be able to use.

Test Plan

See screenshots.

Diff Detail

Branch

dstat2

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

I am really happy about this. Here's a new repo:

{F76777}

{F76779}

{F76781}

{F76783}

{F76786}

{F76788}

Here's it hitting a bug (in this case, the LIMIT 1 thing):

{F76790}

Here's it responding to a "looksoon" hint:

{F76792}

Use a more conventional spelling for the word I chose to spell as "initilizing".

Clear the "needs update" flag a little bit later, after we acquire the lock.

Avoid division by 0.

btrahan accepted this revision.Oct 31 2013, 10:42 PM

btrahan added inline comments.

src/applications/diffusion/conduit/ConduitAPI_diffusion_looksoon_Method.php
33–34	haha

Closed by commit rP40b081820770 (authored by @epriestley).

Show additional status information during repository import
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 16832

src/__phutil_library_map__.php

src/applications/diffusion/conduit/ConduitAPI_diffusion_looksoon_Method.php

src/applications/diffusion/controller/DiffusionController.php

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

src/applications/diffusion/ssh/DiffusionSSHGitReceivePackWorkflow.php

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Show additional status information during repository importClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16832

src/__phutil_library_map__.php

src/applications/diffusion/conduit/ConduitAPI_diffusion_looksoon_Method.php

src/applications/diffusion/controller/DiffusionController.php

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

src/applications/diffusion/ssh/DiffusionSSHGitReceivePackWorkflow.php

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Show additional status information during repository import
ClosedPublic
Actions

Revision Contents
Changeset List