Page MenuHomePhabricator

Show additional status information during repository import
ClosedPublic

Authored by epriestley on Oct 31 2013, 1:21 AM.
Tags
None
Referenced Files
F19506842: D7467.id16832.diff
Fri, Jan 9, 5:07 PM
F19506464: D7467.id16835.diff
Fri, Jan 9, 4:46 PM
F19312457: D7467.id16826.diff
Thu, Dec 25, 12:19 AM
F19016802: D7467.id16827.diff
Nov 23 2025, 5:41 AM
F18873267: D7467.id16835.diff
Nov 5 2025, 8:51 AM
F18867947: D7467.id.diff
Nov 4 2025, 3:44 AM
F18867296: D7467.id.diff
Nov 3 2025, 11:00 PM
F18813917: D7467.id.diff
Oct 20 2025, 7:57 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP40b081820770: Show additional status information during repository import
Summary

Ref T2350. Fixes T2231.

  • Adds log flags around discovery.
  • Adds message flags for "needs update". This is basically an out-of-band hint to the daemons that a repository should be pulled sooner than normal. We set the flag when users push a revision, and expose a Conduit method that arc land will be able to use.
Test Plan

See screenshots.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I am really happy about this. Here's a new repo:

{F76777}

{F76779}

{F76781}

{F76783}

{F76786}

{F76788}

Here's it hitting a bug (in this case, the LIMIT 1 thing):

{F76790}

Here's it responding to a "looksoon" hint:

{F76792}

epriestley updated this revision to Unknown Object (????).Oct 31 2013, 1:28 AM
  • Use a more conventional spelling for the word I chose to spell as "initilizing".
epriestley updated this revision to Unknown Object (????).Oct 31 2013, 1:30 AM
  • Clear the "needs update" flag a little bit later, after we acquire the lock.
epriestley updated this revision to Unknown Object (????).Oct 31 2013, 2:11 PM

Avoid division by 0.

btrahan added inline comments.
src/applications/diffusion/conduit/ConduitAPI_diffusion_looksoon_Method.php
34–35

haha