Page MenuHomePhabricator

Show additional status information during repository import
ClosedPublic

Authored by epriestley on Oct 31 2013, 1:21 AM.
Tags
None
Referenced Files
F14061937: D7467.diff
Mon, Nov 18, 9:31 AM
F14047085: D7467.diff
Thu, Nov 14, 1:49 AM
F14042908: D7467.diff
Tue, Nov 12, 6:52 AM
F14036962: D7467.id16827.diff
Sun, Nov 10, 1:08 PM
F14036915: D7467.id16835.diff
Sun, Nov 10, 12:52 PM
F14036099: D7467.diff
Sun, Nov 10, 8:32 AM
F14026897: D7467.id16835.diff
Fri, Nov 8, 3:28 AM
F14018853: D7467.diff
Tue, Nov 5, 8:19 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP40b081820770: Show additional status information during repository import
Summary

Ref T2350. Fixes T2231.

  • Adds log flags around discovery.
  • Adds message flags for "needs update". This is basically an out-of-band hint to the daemons that a repository should be pulled sooner than normal. We set the flag when users push a revision, and expose a Conduit method that arc land will be able to use.
Test Plan

See screenshots.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I am really happy about this. Here's a new repo:

{F76777}

{F76779}

{F76781}

{F76783}

{F76786}

{F76788}

Here's it hitting a bug (in this case, the LIMIT 1 thing):

{F76790}

Here's it responding to a "looksoon" hint:

{F76792}

epriestley updated this revision to Unknown Object (????).Oct 31 2013, 1:28 AM
  • Use a more conventional spelling for the word I chose to spell as "initilizing".
epriestley updated this revision to Unknown Object (????).Oct 31 2013, 1:30 AM
  • Clear the "needs update" flag a little bit later, after we acquire the lock.
epriestley updated this revision to Unknown Object (????).Oct 31 2013, 2:11 PM

Avoid division by 0.

btrahan added inline comments.
src/applications/diffusion/conduit/ConduitAPI_diffusion_looksoon_Method.php
34–35

haha