Tags

None

Referenced Files

	F15457391: D7467.id16835.diff
	Sun, Mar 30, 4:05 PM

	F15453466: D7467.id16827.diff
	Sat, Mar 29, 12:03 PM

	F15452435: D7467.id16826.diff
	Sat, Mar 29, 4:50 AM

	F15452420: D7467.id.diff
	Sat, Mar 29, 4:39 AM

	F15450122: D7467.diff
	Fri, Mar 28, 2:07 PM

	F15439779: D7467.id.diff
	Wed, Mar 26, 9:25 AM

	F15427847: D7467.id.diff
	Sun, Mar 23, 4:22 PM

	F15415431: D7467.id16827.diff
	Thu, Mar 20, 5:58 AM

View All Files

Subscribers

aran

Tokens

"Mountain of Wealth" token, awarded by btrahan.

Details

Reviewers

btrahan
chad

Maniphest Tasks

Restricted Maniphest Task
Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP40b081820770: Show additional status information during repository import

Summary

Ref T2350. Fixes T2231.

Adds log flags around discovery.
Adds message flags for "needs update". This is basically an out-of-band hint to the daemons that a repository should be pulled sooner than normal. We set the flag when users push a revision, and expose a Conduit method that arc land will be able to use.

Test Plan

See screenshots.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

I am really happy about this. Here's a new repo:

{F76777}

{F76779}

{F76781}

{F76783}

{F76786}

{F76788}

Here's it hitting a bug (in this case, the LIMIT 1 thing):

{F76790}

Here's it responding to a "looksoon" hint:

{F76792}

Use a more conventional spelling for the word I chose to spell as "initilizing".

Clear the "needs update" flag a little bit later, after we acquire the lock.

Avoid division by 0.

btrahan accepted this revision.Oct 31 2013, 10:42 PM

btrahan added inline comments.

src/applications/diffusion/conduit/ConduitAPI_diffusion_looksoon_Method.php
34–35	haha

Closed by commit rP40b081820770 (authored by @epriestley).

Show additional status information during repository import
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 16835

src/__phutil_library_map__.php

src/applications/diffusion/conduit/ConduitAPI_diffusion_looksoon_Method.php

src/applications/diffusion/controller/DiffusionController.php

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

src/applications/diffusion/ssh/DiffusionSSHGitReceivePackWorkflow.php

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Show additional status information during repository importClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16835

src/__phutil_library_map__.php

src/applications/diffusion/conduit/ConduitAPI_diffusion_looksoon_Method.php

src/applications/diffusion/controller/DiffusionController.php

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

src/applications/diffusion/ssh/DiffusionSSHGitReceivePackWorkflow.php

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Show additional status information during repository import
ClosedPublic
Actions

Revision Contents
Changeset List