Fix an issue with viewing an undiscovered commit in Diffusion
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 3:00 PM.

Tags

None

Referenced Files

	F18866591: D7448.id.diff
	Nov 3 2025, 6:04 PM

	F18766783: D7448.id16777.diff
	Oct 7 2025, 6:31 PM

	F18765248: D7448.diff
	Oct 7 2025, 10:24 AM

	F18764346: D7448.id.diff
	Oct 7 2025, 5:31 AM

	F18760035: D7448.id16801.diff
	Oct 6 2025, 7:39 AM

	F18594248: D7448.diff
	Sep 12 2025, 5:33 PM

	F18593025: D7448.id.diff
	Sep 12 2025, 1:42 PM

	F18585304: D7448.diff
	Sep 11 2025, 2:54 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP70b53c49fd0c: Fix an issue with viewing an undiscovered commit in Diffusion

Summary

If you load Diffusion between a repository being pulled and discovered, you can end up with a valid commit reference that hasn't been discovered yet. Don't fatal.

Test Plan

Saw somewhat-helpful error page instead of fatal.

Diff Detail

Branch

commitparse

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Oct 30 2013, 7:31 PM

Closed by commit rP70b53c49fd0c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

request/

DiffusionRequest.php

4 lines

Diff 16777

View Options

src/applications/diffusion/request/DiffusionRequest.php

Fix an issue with viewing an undiscovered commit in DiffusionClosedPublicActions