Fix an issue with viewing an undiscovered commit in Diffusion
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 3:00 PM.

Tags

None

Referenced Files

	F15414574: D7448.id.diff
	Thu, Mar 20, 1:15 AM

	F15404978: D7448.diff
	Tue, Mar 18, 9:53 AM

	F15386003: D7448.id.diff
	Fri, Mar 14, 11:50 PM

	Unknown Object (File)
	Feb 17 2025, 2:55 AM

	Unknown Object (File)
	Feb 17 2025, 1:46 AM

	Unknown Object (File)
	Feb 3 2025, 1:25 AM

	Unknown Object (File)
	Jan 29 2025, 4:58 AM

	Unknown Object (File)
	Jan 2 2025, 5:17 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP70b53c49fd0c: Fix an issue with viewing an undiscovered commit in Diffusion

Summary

If you load Diffusion between a repository being pulled and discovered, you can end up with a valid commit reference that hasn't been discovered yet. Don't fatal.

Test Plan

Saw somewhat-helpful error page instead of fatal.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 30 2013, 7:31 PM

Closed by commit rP70b53c49fd0c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

request/

DiffusionRequest.php

4 lines

Diff 16801

View Options

src/applications/diffusion/request/DiffusionRequest.php

Fix an issue with viewing an undiscovered commit in DiffusionClosedPublicActions