Page MenuHomePhabricator

Serve Git reads over SSH
ClosedPublic

Authored by epriestley on Oct 26 2013, 7:22 PM.
Tags
None
Referenced Files
F19507407: D7424.diff
Fri, Jan 9, 8:20 PM
F19506091: D7424.id16750.diff
Fri, Jan 9, 4:40 PM
F19050586: D7424.id16717.diff
Nov 27 2025, 8:19 PM
F19008291: D7424.diff
Nov 21 2025, 9:42 PM
F18809423: D7424.id16750.diff
Oct 19 2025, 1:50 PM
F18802706: D7424.id.diff
Oct 17 2025, 8:03 PM
F18704070: D7424.diff
Sep 28 2025, 6:10 AM
F18701839: D7424.diff
Sep 27 2025, 9:25 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP9a2e45ef12ea: Serve Git reads over SSH
Summary

Like D7423, but for SSH.

Test Plan

Ran git clone ssh://..., got a clone.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

so this closes stdin?

src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

Yeah -- by default, write() closes the subprocess's stdin, unless the second parameter ("$keep_pipe") is set to true. At some point, it would probably be cleaner to replace this with $exec_channel->closeWriteChannel() or something, but that doesn't exist yet.