Page MenuHomePhabricator

Serve Git reads over SSH
ClosedPublic

Authored by epriestley on Oct 26 2013, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 25, 8:22 PM
Unknown Object (File)
Fri, Aug 9, 12:25 PM
Unknown Object (File)
Aug 2 2024, 7:03 AM
Unknown Object (File)
Aug 2 2024, 7:00 AM
Unknown Object (File)
Aug 2 2024, 6:59 AM
Unknown Object (File)
Aug 2 2024, 6:58 AM
Unknown Object (File)
Jul 15 2024, 2:39 PM
Unknown Object (File)
Jul 13 2024, 11:14 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP9a2e45ef12ea: Serve Git reads over SSH
Summary

Like D7423, but for SSH.

Test Plan

Ran git clone ssh://..., got a clone.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

so this closes stdin?

src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

Yeah -- by default, write() closes the subprocess's stdin, unless the second parameter ("$keep_pipe") is set to true. At some point, it would probably be cleaner to replace this with $exec_channel->closeWriteChannel() or something, but that doesn't exist yet.