Page MenuHomePhabricator

Serve Git reads over SSH
ClosedPublic

Authored by epriestley on Oct 26 2013, 7:22 PM.
Tags
None
Referenced Files
F14059697: D7424.diff
Sun, Nov 17, 9:08 PM
F14049825: D7424.diff
Thu, Nov 14, 2:52 PM
F14035138: D7424.diff
Sun, Nov 10, 4:30 AM
F14033210: D7424.id16750.diff
Sat, Nov 9, 5:05 PM
F14033209: D7424.id16717.diff
Sat, Nov 9, 5:05 PM
F14033208: D7424.id.diff
Sat, Nov 9, 5:05 PM
F14027899: D7424.id16717.diff
Fri, Nov 8, 10:13 AM
F14020829: D7424.diff
Wed, Nov 6, 3:00 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP9a2e45ef12ea: Serve Git reads over SSH
Summary

Like D7423, but for SSH.

Test Plan

Ran git clone ssh://..., got a clone.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

so this closes stdin?

src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

Yeah -- by default, write() closes the subprocess's stdin, unless the second parameter ("$keep_pipe") is set to true. At some point, it would probably be cleaner to replace this with $exec_channel->closeWriteChannel() or something, but that doesn't exist yet.