Serve Git reads over SSH
ClosedPublic
Actions

Authored by epriestley on Oct 26 2013, 7:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 17, 1:55 AM

	Unknown Object (File)
	Tue, Jan 14, 11:14 PM

	Unknown Object (File)
	Mon, Jan 13, 2:04 PM

	Unknown Object (File)
	Tue, Dec 31, 8:09 PM

	Unknown Object (File)
	Fri, Dec 27, 12:54 AM

	Unknown Object (File)
	Fri, Dec 27, 12:54 AM

	Unknown Object (File)
	Fri, Dec 27, 12:42 AM

	Unknown Object (File)
	Sun, Dec 22, 2:03 PM

Subscribers

Details

Reviewers

btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

Summary

Like D7423, but for SSH.

Test Plan

Ran git clone ssh://..., got a clone.

Lint

Lint Skipped

Unit

Tests Skipped

btrahan added inline comments.

src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71	so this closes stdin?

src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71	Yeah -- by default, write() closes the subprocess's stdin, unless the second parameter ("$keep_pipe") is set to true. At some point, it would probably be cleaner to replace this with $exec_channel->closeWriteChannel() or something, but that doesn't exist yet.