Page MenuHomePhabricator

Serve Git reads over SSH
ClosedPublic

Authored by epriestley on Oct 26 2013, 7:22 PM.
Tags
None
Referenced Files
F15467879: D7424.diff
Thu, Apr 3, 6:16 PM
F15388223: D7424.id.diff
Sat, Mar 15, 3:29 AM
F15387556: D7424.diff
Sat, Mar 15, 2:35 AM
F15375934: D7424.id16750.diff
Thu, Mar 13, 12:43 AM
Unknown Object (File)
Feb 28 2025, 12:06 PM
Unknown Object (File)
Feb 27 2025, 3:18 AM
Unknown Object (File)
Feb 26 2025, 6:32 AM
Unknown Object (File)
Feb 24 2025, 2:59 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP9a2e45ef12ea: Serve Git reads over SSH
Summary

Like D7423, but for SSH.

Test Plan

Ran git clone ssh://..., got a clone.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

so this closes stdin?

src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

Yeah -- by default, write() closes the subprocess's stdin, unless the second parameter ("$keep_pipe") is set to true. At some point, it would probably be cleaner to replace this with $exec_channel->closeWriteChannel() or something, but that doesn't exist yet.