Page MenuHomePhabricator
Differential D7408

Work around a bug in PHP 5.3-ish with abstract methods in interfaces
ClosedPublic
Actions

Authored by epriestley on Oct 25 2013, 10:56 PM.
Tags
None
Referenced Files
F13886165: D7408.diff
Thu, Oct 3, 5:20 PM
F13885628: D7408.diff
Thu, Oct 3, 3:20 PM
F13885621: D7408.id.diff
Thu, Oct 3, 3:17 PM
F13885615: D7408.id16691.diff
Thu, Oct 3, 3:16 PM
F13885608: D7408.id16694.diff
Thu, Oct 3, 3:15 PM
Unknown Object (File)
Sun, Sep 22, 7:41 AM
Unknown Object (File)
Sat, Sep 21, 2:42 PM
Unknown Object (File)
Sat, Sep 21, 11:00 AM
View All Files
Subscribers
aran
chad

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP1975bdfb3660: Work around a bug in PHP 5.3-ish with abstract methods in interfaces
Summary

@chad is hitting an issue described in P961, which I think is this bug in PHP: https://bugs.php.net/bug.php?id=43200

Work around it by defining a "PHIDInterface" and having both "Flaggable" and "Policy" extend it, so that there is only one getPHID() declaration.

Test Plan

shrug~

Diff Detail

Branch
3abstract5me
Lint
Lint Passed
Unit
Tests Passed

Revision Contents
Changeset List

PathSize
src/
3 lines
applications/
flag/
interface/
4 lines
phid/
interface/
7 lines
policy/
interface/
3 lines

Diff 16691

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/flag/interface/PhabricatorFlaggableInterface.php

Loading...
View Options

src/applications/phid/interface/PhabricatorPHIDInterface.php

Loading...
View Options

src/applications/policy/interface/PhabricatorPolicyInterface.php

Loading...
Phabricator · Built by Phacility