Improve consistency of policy enforcement on new repository edit UI
ClosedPublic
Actions

Authored by epriestley on Oct 25 2013, 9:11 PM.

Tags

None

Referenced Files

	F14860659: D7406.diff
	Fri, Feb 7, 4:30 AM

	Unknown Object (File)
	Wed, Feb 5, 1:27 AM

	Unknown Object (File)
	Mon, Feb 3, 5:31 PM

	Unknown Object (File)
	Sun, Feb 2, 9:18 PM

	Unknown Object (File)
	Sat, Feb 1, 6:45 AM

	Unknown Object (File)
	Mon, Jan 27, 5:08 PM

	Unknown Object (File)
	Sun, Jan 12, 11:38 PM

	Unknown Object (File)
	Dec 10 2024, 2:38 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPe81bad9ba21f: Improve consistency of policy enforcement on new repository edit UI

Summary

Ref T2231. The policy rules are a little murky right now: the "Edit Repository" link requires CAN_EDIT, but the actualy page doesn't. Instead, require CAN_EDIT for the edit page.

Test Plan

As a user without CAN_EDIT, viewed a repository and clicked the edit link.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 25 2013, 10:48 PM

btrahan added inline comments.

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
28	this should be CAN_EDIT, right? (On that note, I could imagine CAN_CREATE being desired for repositories (and projects))

epriestley added inline comments.Oct 25 2013, 10:54 PM

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
28	Ack, good catch! (We have a create policy for projects already and I'll add one for repositories pretty soon.)

Closed by commit rPe81bad9ba21f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryCreateController.php

13 lines

DiffusionRepositoryEditController.php

95 lines

Diff 16693

View Options

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php