Ref T2231. The policy rules are a little murky right now: the "Edit Repository" link requires CAN_EDIT, but the actualy page doesn't. Instead, require CAN_EDIT for the edit page.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rPe81bad9ba21f: Improve consistency of policy enforcement on new repository edit UI
As a user without CAN_EDIT, viewed a repository and clicked the edit link.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/diffusion/controller/DiffusionRepositoryCreateController.php | ||
|---|---|---|
| 28 | this should be CAN_EDIT, right? (On that note, I could imagine CAN_CREATE being desired for repositories (and projects)) | |
| src/applications/diffusion/controller/DiffusionRepositoryCreateController.php | ||
|---|---|---|
| 28 | Ack, good catch! (We have a create policy for projects already and I'll add one for repositories pretty soon.) | |