Page MenuHomePhabricator

Move "Remote URI" to modern repository editor thing
ClosedPublic

Authored by epriestley on Oct 25 2013, 8:20 PM.
Tags
None
Referenced Files
F13893040: D7405.diff
Sat, Oct 5, 5:20 AM
Unknown Object (File)
Thu, Oct 3, 2:50 PM
Unknown Object (File)
Thu, Oct 3, 2:46 PM
Unknown Object (File)
Thu, Oct 3, 2:45 PM
Unknown Object (File)
Thu, Oct 3, 2:43 PM
Unknown Object (File)
Wed, Oct 2, 7:15 AM
Unknown Object (File)
Sat, Sep 21, 6:44 AM
Unknown Object (File)
Fri, Sep 20, 12:18 AM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPb57b72368c3c: Move "Remote URI" to modern repository editor thing
Summary

Ref T2231. Allows you to edit the remote URI and credentials.

This is a little bit funky because I'm reusing some of the pages on the new (not-yet-hooked-up) create form. Specifically, it had pages like this:

  • Repo Type
  • Name/Callsign/Remote
  • Auth
  • Done

I split "Name/Callsign/Remote" into "Name/Callsign" and "Remote", then when editing the remote I just take you through "Remote" and "Auth" and then back. This lets us reuse the giant pile of protocol/URI sanity checking logic and ends up being pretty clean, although it's a little weird that the "Create" controller does both full-create and edit-remote.

Test Plan

See screenshots.

Diff Detail

Branch
dbranches4
Lint
Lint Passed
Unit
Tests Passed