Paths

Table of Contentst

Improve exception behavior for Herald commit rules which fail to load diff context
ClosedPublic
Actions

Authored by epriestley on Oct 23 2013, 12:49 AM.

Tags

None

Referenced Files

	F15191917: D7384.diff
	Sat, Feb 22, 12:39 AM

	Unknown Object (File)
	Sat, Feb 15, 10:18 AM

	Unknown Object (File)
	Sun, Feb 9, 10:22 AM

	Unknown Object (File)
	Sun, Feb 9, 10:22 AM

	Unknown Object (File)
	Sun, Feb 9, 10:22 AM

	Unknown Object (File)
	Sun, Feb 9, 10:22 AM

	Unknown Object (File)
	Fri, Jan 31, 3:20 PM

	Unknown Object (File)
	Mon, Jan 27, 7:51 AM

View All Files

Subscribers

aran

bigo

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP2c3d071a26a9: Improve exception behavior for Herald commit rules which fail to load diff…

Summary

This code is a little funky right now, and can return array("error message") and then try to call getHunks() on it. Additionally, each field loads the commit's changes separately.

Instead, load the commit's changes once and cache them, and handle exceptions appropriately.

Test Plan

Created a rule like "changed, added, removed content all match /.*/" to force all fields to generate.
Ran it successfully.
Faked an error and ran it, got reasonable results.

Diff Detail

Branch

cadapter

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Valid run:

{F73328}

Faked failure:

{F73330}

btrahan accepted this revision.Oct 23 2013, 2:34 AM

Closed by commit rP2c3d071a26a9 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldCommitAdapter.php

86 lines

Diff 16632

View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Improve exception behavior for Herald commit rules which fail to load diff contextClosedPublicActions