Page MenuHomePhabricator

Add printable support to CSS
ClosedPublic

Authored by epriestley on Oct 19 2013, 8:54 PM.
Tags
None
Referenced Files
F13238356: D7363.diff
Tue, May 21, 6:56 PM
F13235509: D7363.id16578.diff
Tue, May 21, 5:37 AM
F13223924: D7363.id16579.diff
Sun, May 19, 5:22 AM
F13213156: D7363.diff
Fri, May 17, 7:27 AM
Unknown Object (File)
Tue, May 7, 9:27 AM
Unknown Object (File)
Fri, May 3, 9:19 AM
Unknown Object (File)
Thu, Apr 25, 1:53 AM
Unknown Object (File)
Apr 16 2024, 5:50 PM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP87ccca32b66f: Add printable support to CSS
Summary

Fixes T2146. This is a really simple approach, you just do:

!print .rule {
  whatever: blah;
}

And it transforms it into:

.printable .rule {
  whatever: blah;
}

@media print {
  .rule {
    whatever: blah;
  }
}

So we end up with these rules twice, but they should compress well and we shouldn't need that many of them, and this fix is way way simpler than all the nonsense I discussed in T2146.

Test Plan
  • Added a unit test.
  • Added a simple rule to throw away the menubar when printing.
  • Checked the latter with /?__print__=1.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped