Use property tabs in Files
ClosedPublic
Actions

Authored by epriestley on Oct 19 2013, 2:10 PM.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP3643fe1498f1: Use property tabs in Files

Summary

See screenshots. Some simplifications:

Tabbed and non-tabbed lists are now allowed to be mixed. We just make the non-tabbed lists permanent and put them on the bottom (e.g., image and audio data in Files).
You can provide a tab name instead of an entire tab object and we'll build an object for you.
We respect setSelected() on the tab objects now.

Test Plan

See screenshots.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

{F72899}

{F72897}

{F72900}

{F72898}

At least for this use case, the action list being bound to the first tab feels a little bit funky to me -- I still want to keep eye on that as we move forward.

Reorganize properties to make more sense.

Details: Author, Created
File Info: Mime type, size, width, height
Storage: engine, format, handle
Attached: attached objects

Do we even need so many tabs? It's odd to have a tab with just 1 or 2 properties on it.

Meta thought on tabs is for containing larger amounts of information that we previously might have provided. So a reviewers tab in Differential might list in a table each reviewer, their full name, photo, and last action. Then it might expand out on 'project reviewers' and whom from that project participated in the review. This information is likely overkill in the Details summery, but perfectly OK to be overly verbose under the tab (utilizing all the extra space). I think once we do a couple filled out tabs like Reviewers, Lint, the action list thing shouldn't feel as weird.

Alternatively, if that still seems weird we can just make the tabs collapse and persist the actions. I think there are solutions either way.