Fix daemon auth issue
ClosedPublic
Actions

Authored by epriestley on Oct 19 2013, 12:35 AM.

Tags

None

Referenced Files

	F14022018: D7356.diff
	Wed, Nov 6, 2:47 PM

	F14017042: D7356.id16566.diff
	Mon, Nov 4, 1:53 PM

	F14008968: D7356.id16566.diff
	Wed, Oct 30, 8:19 AM

	F13976130: D7356.diff
	Fri, Oct 18, 12:58 PM

	F13976035: D7356.id16566.diff
	Fri, Oct 18, 12:36 PM

	F13974340: D7356.id.diff
	Fri, Oct 18, 5:11 AM

	F13959402: D7356.id16563.diff
	Mon, Oct 14, 7:15 PM

	Unknown Object (File)
	Sun, Oct 13, 10:58 PM

View All Files

Subscribers

aran

poop

Details

Reviewers

poop
btrahan

Commits

Restricted Diffusion Commit
rP7180199d1370: Fix daemon auth issue

Summary

I touched this code recently but it needs an unusual special case because we call through with the "omnipotent user" from the daemons. As per the TODO below, this will all get cleaned up at some point.

Test Plan

Will make @poop verify.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Also, make the call with the omnipotent user. Broader policy controls makes parsing commits as the author fairly silly, I think. Parsing commits does not cause actions or side effects.

success!

Closed by commit rP7180199d1370 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

call/

ConduitCall.php

3 lines

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

2 lines

Diff 16566

View Options

src/applications/conduit/call/ConduitCall.php